Accumulate exp warnings with logger #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejG604
force-pushed
the
accumulate-exp-warnings-with-logger
branch
from
f9df159 to
0c7d90d
Compare
MaciejG604
force-pushed
the
accumulate-exp-warnings-with-logger
branch
2 times, most recently
from
7af1f28 to
32a6e51
Compare
MaciejG604
force-pushed
the
accumulate-exp-warnings-with-logger
branch
from
32a6e51 to
905a15c
Compare
This was referenced Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2294
Replacement for #2358 that uses a mutable logger instead of return values.
Also handles experimental sub-commands, options, directives and config keys instead of just directives.