Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IntelliJ version to 2022.2.3 #290

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

virtuslab-bot
Copy link
Collaborator

@virtuslab-bot virtuslab-bot commented Oct 16, 2022

Updates the default IntelliJ Version to the newest release. Please, check currently used version of the scala plugin in two following files: https://github.com/VirtusLab/ide-probe/blob/master/extensions/scala/tests/src/test/resources/scala.conf and https://github.com/VirtusLab/ide-probe/blob/master/core/driver/tests/src/test/scala/org/virtuslab/ideprobe/ProbeDriverTest.scala and verify if it is compatible with the new intelliJ IDEA version 2022.2.3 here: https://plugins.jetbrains.com/plugin/1347-scala/versions. If the currently used version of the scala plugin is NOT compatible with new IntelliJ release - please update it in both files in a separate commit.

@virtuslab-bot virtuslab-bot force-pushed the update_intellij_version/2022.2.3 branch from b0bb63e to 21e8a3f Compare October 16, 2022 00:07
@LukaszKontowski
Copy link
Contributor

If the version of the scala plugin used in https://github.com/VirtusLab/ide-probe/blob/master/extensions/scala/tests/src/test/resources/scala.conf is NOT compatible - please update it in a separate commit.

done

@virtuslab-bot virtuslab-bot force-pushed the update_intellij_version/2022.2.3 branch from 6ca2dc5 to 0cd77c0 Compare October 18, 2022 00:08
@LukaszKontowski LukaszKontowski force-pushed the update_intellij_version/2022.2.3 branch from 62619a7 to 3b5e8ba Compare October 18, 2022 08:30
@LukaszKontowski

This comment was marked as outdated.

@virtuslab-bot virtuslab-bot force-pushed the update_intellij_version/2022.2.3 branch from 3b5e8ba to be63127 Compare October 19, 2022 00:09
@LukaszKontowski
Copy link
Contributor

It showed up that there is one more file, which needs to be updated with the new scala plugin version:
core/driver/tests/src/test/scala/org/virtuslab/ideprobe/ProbeDriverTest.scala

@LukaszKontowski LukaszKontowski marked this pull request as draft October 19, 2022 10:41
@LukaszKontowski
Copy link
Contributor

will undraft it when bugs are fixed

@LukaszKontowski
Copy link
Contributor

@LukaszKontowski
Copy link
Contributor

ProbablyJsonRpcEndpoint#sendRequest does not work as expected with new IntelliJ release.
For example - it does not collect errors - ProbeDriverTest#collectErrors() collects 0 errors, although logs like below are being printed out:

[intellij-stderr] 2022-10-19 14:22:31,083 [   8254] SEVERE - #c.i.o.a.i.FlushQueue - Test failure from ThrowingAction
[intellij-stderr] java.lang.RuntimeException: Test failure from ThrowingAction
[intellij-stderr] 	at org.virtuslab.ideprobe.test.ThrowingAction.actionPerformed(ThrowingAction.scala:9)
[intellij-stderr] 	at com.intellij.openapi.actionSystem.ex.ActionUtil.doPerformActionOrShowPopup(ActionUtil.java:315)
...

@virtuslab-bot virtuslab-bot force-pushed the update_intellij_version/2022.2.3 branch from 9bf0cb8 to f5e1513 Compare October 20, 2022 00:08
@LukaszKontowski
Copy link
Contributor

Our logic works fine for releases up to 2021.3.3. Tests fail since 2022.1 release.

@LukaszKontowski
Copy link
Contributor

Didn't find anything that would sound related to the problem in 2022.2.1 release notes https://youtrack.jetbrains.com/articles/IDEA-A-149/IntelliJ-IDEA-20221-2215080210-build-Release-Notes

@LukaszKontowski
Copy link
Contributor

LukaszKontowski commented Oct 20, 2022

What does not work well for new releases, but worked well for older ones:
org.virtuslab.ideprobe.ProbeDriver#send(Endpoints.Messages) does not return proper results. In fact it does not collect messages properly.
The only message it was able to collect in my local testing was in fact unrelated to tested logic:
IdeMessage(Warn,Download IntelliJ IDEA for Apple Silicon for better performance and stability.,None)

In more detail:
JsonRpcConnection#sendRequest(method: String, params: SerializedJson): Future[Response] returns Future with a org.virtuslab.ideprobe.jsonrpc.JsonRpc.Response object - and this object (for some reason) does not contain valid result. Instead, it's result (field) contains
{"data":null} string value.

@LukaszKontowski
Copy link
Contributor

LukaszKontowski commented Oct 20, 2022

For 2021 releases we had:

request[action/invokeAsync]: "org.virtuslab.ideprobe.test.ThrowingAction"
response: ()
[intellij-stderr] 2022-10-20 18:11:53,346 [  11561]  ERROR - pplication.impl.LaterInvocator - Test failure from ThrowingAction 
[intellij-stderr] java.lang.RuntimeException: Test failure from ThrowingAction
... (stack trace goes here)

and for 2022 releases we have:

request[action/invokeAsync]: "org.virtuslab.ideprobe.test.ThrowingAction"
response: ()
[intellij-stderr] 2022-10-20 18:07:54,824 [   9111] SEVERE - #c.i.o.a.i.FlushQueue - Test failure from ThrowingAction
[intellij-stderr] java.lang.RuntimeException: Test failure from ThrowingAction
... (stack trace goes here)

so, the change is
from ERROR - pplication.impl.LaterInvocator
to SEVERE - #c.i.o.a.i.FlushQueue
which might be the reason of current problem

@LukaszKontowski
Copy link
Contributor

LukaszKontowski commented Oct 20, 2022

Looks like changes in https://github.com/JetBrains/intellij-community/blob/master/platform/platform-impl/src/com/intellij/idea/IdeaLogger.java might be the reason - JetBrains/intellij-community@bb32191#diff-ccbe083e0d45bf038f1e293fe381a649b52a9c15dd8a699f8dca8b9b888a7fff in particular.

Related story: https://youtrack.jetbrains.com/issue/IDEA-265069

More generally - looks like we have to switch from using log4j to use java.util.logging when it comes to retrieving messages from IntelliJ - to be compatible with new IntelliJ logic. However - only for releases 2022 +

@virtuslab-bot virtuslab-bot force-pushed the update_intellij_version/2022.2.3 branch from f5e1513 to 072a8d4 Compare October 21, 2022 00:09
@LukaszKontowski
Copy link
Contributor

Changes from #187 could be helpoful

@virtuslab-bot virtuslab-bot force-pushed the update_intellij_version/2022.2.3 branch 3 times, most recently from e2d4a3d to 239fc3f Compare October 30, 2022 00:05
@virtuslab-bot virtuslab-bot force-pushed the update_intellij_version/2022.2.3 branch 3 times, most recently from 9fd62f0 to 92c079f Compare November 4, 2022 00:49
@virtuslab-bot virtuslab-bot force-pushed the update_intellij_version/2022.2.3 branch from 92c079f to 2522b28 Compare November 8, 2022 00:05
@virtuslab-bot virtuslab-bot force-pushed the update_intellij_version/2022.2.3 branch 2 times, most recently from cb1e381 to 560bc3a Compare November 20, 2022 00:05
@virtuslab-bot virtuslab-bot force-pushed the update_intellij_version/2022.2.3 branch from 560bc3a to 0004d43 Compare November 23, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants