Fix most of the compilation warnings #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PawelLipski
reviewed
Aug 8, 2022
core/driver/sources/src/main/scala/org/virtuslab/ideprobe/Shell.scala
Outdated
Show resolved
Hide resolved
PawelLipski
reviewed
Aug 8, 2022
core/driver/sources/src/main/scala/org/virtuslab/ideprobe/Shell.scala
Outdated
Show resolved
Hide resolved
PawelLipski
reviewed
Aug 8, 2022
core/driver/sources/src/main/scala/org/virtuslab/ideprobe/dependencies/Resource.scala
Show resolved
Hide resolved
PawelLipski
reviewed
Aug 8, 2022
core/probePlugin/src/main/scala/org/virtuslab/ideprobe/handlers/ExpandMacro.scala
Show resolved
Hide resolved
PawelLipski
reviewed
Aug 8, 2022
core/probePlugin/src/main/scala/org/virtuslab/ideprobe/handlers/IntelliJApi.scala
Outdated
Show resolved
Hide resolved
PawelLipski
reviewed
Aug 8, 2022
PawelLipski
reviewed
Aug 9, 2022
core/driver/test-plugin/src/main/scala/org/virtuslab/ideprobe/test/OpenWindowAction.scala
Outdated
Show resolved
Hide resolved
This reverts commit ebcaa16.
…probe into unused_warnings_fix
LukaszKontowski
changed the title
PawelLipski
approved these changes
Aug 9, 2022
| @@ -109,7 +109,7 @@ object Builds extends IntelliJApi { | |||
| compileContext: CompileContext | |||
| ): Unit = { | |||
| def messages(category: CompilerMessageCategory): Seq[BuildMessage] = { | |||
| compileContext.getMessages(category).map { msg => | |||
| compileContext.getMessages(category).toIndexedSeq.map { msg => | |||
There was a problem hiding this comment.
why this toIndexedSeq conversion happens everywhere?
There was a problem hiding this comment.
Without it (as we have on master now) - we are having following warnings (which contain answer, why):
[warn] /Users/lkontowski/code/ide-probe/core/probePlugin/src/main/scala/org/virtuslab/ideprobe/handlers/Builds.scala:112:50: method copyArrayToImmutableIndexedSeq in class LowPriorityImplicits2 is deprecated (since 2.13.0): Implicit conversions from Array to immutable.IndexedSeq are implemented by copying; Use the more efficient non-copying ArraySeq.unsafeWrapArray or an explicit toIndexedSeq call
[warn] compileContext.getMessages(category).map { msg =>
[warn] ^
[warn] one warning found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #223