Skip to content

Commit

Permalink
Make default driver launch command array non-empty (#313)
Browse files Browse the repository at this point in the history
* Make default driver launch command array non-empty

* Uppdate IdeProbeConfigTest
  • Loading branch information
LukaszKontowski authored Nov 2, 2022
1 parent 91a1654 commit c9054b1
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
11 changes: 7 additions & 4 deletions core/driver/sources/src/main/resources/reference.conf
Original file line number Diff line number Diff line change
Expand Up @@ -229,11 +229,14 @@ probe {
launch {

// `driver.launch.command` is a string array transformed into the command used to launch the IDE (each string
// from the array is a single element of the command). By default, the driver uses the `idea` command,
// but you can specify a custom command by using this config.
// Note, that the `idea` command is available on the PATH. If you want to provide your custom command -
// from the array is a single element of the command). By default, the driver uses the "idea" command, which
// runs the default "idea" script/executable file (`idea` for macOs, `idea.sh` for Linux). You can specify
// a custom command by using this config. For example, you can add command line options that should be
// appended to the command. You can also use a totally different command, like starting your own script, which
// starts IDE in a custom way.
// Note, that the "idea" command is available on the PATH. If you want to provide your custom command -
// make sure it is available on the PATH as well.
command = []
command = ["idea"]

// `driver.launch.timeout` is the maximum time the driver will wait for the IDE to connect the probe.
// After exceeding this time, the whole test fails. Note: format for `timeout` should be compatible with
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class IdeProbeConfigTest extends IdeProbeFixture {
assertEquals(defaultJbrRepositoriesPatterns, probeConfig.resolvers.jbr.repositories)
assertEquals(0, probeConfig.resolvers.retries)
// tests for the driver: DriverConfig field
assertEquals(Seq.empty, probeConfig.driver.launch.command)
assertEquals(Seq("idea"), probeConfig.driver.launch.command)
assertEquals(30.seconds, probeConfig.driver.launch.timeout)
assertEquals(false, probeConfig.driver.check.errors.enabled)
assertEquals(Seq(".*"), probeConfig.driver.check.errors.includeMessages)
Expand Down

0 comments on commit c9054b1

Please sign in to comment.