Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup and use of pylint #2

Merged
merged 3 commits into from
Oct 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,23 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install flake8 mypy
python -m pip install flake8 mypy pylint
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
- name: Lint with flake8
run: |
flake8 ./tests/*.py ./logic/*.py --max-line-length=120
- name: Lint with pylint
continue-on-error: true
run: |
pylint ./tests/*.py ./logic/*.py --max-line-length=120 --disable W1114 --disable C0103
# W1114: arguments-out-of-order (pylint getting confused)
# C0103: invalid-name
# R0914: too-many-locals
# R0911: too-many-return-statements
# R0912: too-many-branches
# R0915: too-many-statements
# R0903: too-few-public-methods

- name: Type checker with mypy
run: |
mypy ./tests/*.py ./logic/*.py
Expand Down
6 changes: 4 additions & 2 deletions logic/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
from .proof import Prover, Proof
from .proposition import Proposition, IMPLY, IFF, AND, OR, NOT
"""Logic is a predicate logic simulator and a automated prover"""

from .proof import Proof, Prover
from .proposition import AND, IFF, IMPLY, NOT, OR, Proposition

__all__ = ["Proposition", "Proof", "Prover", "IMPLY", "IFF", "AND", "OR", "NOT"]
Loading
Loading