Skip to content

Commit

Permalink
11 warnings to go
Browse files Browse the repository at this point in the history
  • Loading branch information
Viincenttt committed May 14, 2024
1 parent 2b47d46 commit ec2e6f9
Show file tree
Hide file tree
Showing 32 changed files with 78 additions and 75 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using System;
using Mollie.Api.Models.Payment;
using Mollie.Api.Models.Payment.Response;
using Mollie.Api.Models.Payment.Response.Specific;
using Mollie.Api.Models.Payment.Response.PaymentSpecificParameters;

namespace Mollie.Api.Framework.Factories {
internal class PaymentResponseFactory {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Request {
namespace Mollie.Api.Models.Payment.Request.PaymentSpecificParameters {
public record ApplePayPaymentRequest : PaymentRequest {
public ApplePayPaymentRequest()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Request {
namespace Mollie.Api.Models.Payment.Request.PaymentSpecificParameters {
public record BankTransferPaymentRequest : PaymentRequest {
public BankTransferPaymentRequest() {
Method = PaymentMethod.BankTransfer;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Request {
namespace Mollie.Api.Models.Payment.Request.PaymentSpecificParameters {
public record CreditCardPaymentRequest : PaymentRequest {
public CreditCardPaymentRequest() {
Method = PaymentMethod.CreditCard;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Request {
namespace Mollie.Api.Models.Payment.Request.PaymentSpecificParameters {
public record GiftcardPaymentRequest : PaymentRequest {
public GiftcardPaymentRequest() {
Method = PaymentMethod.GiftCard;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Request {
namespace Mollie.Api.Models.Payment.Request.PaymentSpecificParameters {
public record IdealPaymentRequest : PaymentRequest {
public IdealPaymentRequest() {
Method = PaymentMethod.Ideal;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
namespace Mollie.Api.Models.Payment.Request {
namespace Mollie.Api.Models.Payment.Request.PaymentSpecificParameters {
public static class KbcIssuer {
public const string Kbc = "kbc";
public const string Cbc = "cbc";
}
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Request {
namespace Mollie.Api.Models.Payment.Request.PaymentSpecificParameters {
public record KbcPaymentRequest : PaymentRequest {
public KbcPaymentRequest() {
Method = PaymentMethod.Kbc;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Request {
namespace Mollie.Api.Models.Payment.Request.PaymentSpecificParameters {
public record PayPalPaymentRequest : PaymentRequest {
public PayPalPaymentRequest() {
Method = PaymentMethod.PayPal;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Request {
namespace Mollie.Api.Models.Payment.Request.PaymentSpecificParameters {
public record PaySafeCardPaymentRequest : PaymentRequest {
public PaySafeCardPaymentRequest() {
Method = PaymentMethod.PaySafeCard;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Request
namespace Mollie.Api.Models.Payment.Request.PaymentSpecificParameters
{
public record Przelewy24PaymentRequest : PaymentRequest
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Request {
namespace Mollie.Api.Models.Payment.Request.PaymentSpecificParameters {
public record SepaDirectDebitRequest : PaymentRequest {
public SepaDirectDebitRequest() {
Method = PaymentMethod.DirectDebit;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using System;

namespace Mollie.Api.Models.Payment.Response.Specific {
namespace Mollie.Api.Models.Payment.Response.PaymentSpecificParameters {
public record BancontactPaymentResponse : PaymentResponse {
public required BancontactPaymentResponseDetails Details { get; init; }
}
Expand All @@ -12,21 +12,21 @@ public record BancontactPaymentResponseDetails {
public string? CardNumber { get; set; }

/// <summary>
/// Only available if the payment is completed - Unique alphanumeric representation of card, usable for
/// identifying returning customers. This field is deprecated as of November 28th, 2019. The fingerprint
/// is now unique per transaction what makes it not usefull anymore for identifying returning customers.
/// Only available if the payment is completed - Unique alphanumeric representation of card, usable for
/// identifying returning customers. This field is deprecated as of November 28th, 2019. The fingerprint
/// is now unique per transaction what makes it not usefull anymore for identifying returning customers.
/// Use the consumerAccount field instead.
/// </summary>
[Obsolete(@"This field is deprecated as of November 28th, 2019. The fingerprint is now unique per
[Obsolete(@"This field is deprecated as of November 28th, 2019. The fingerprint is now unique per
transaction what makes it not usefull anymore for identifying returning customers. Use the consumerAccount field instead.")]
public string? CardFingerprint { get; set; }

/// <summary>
/// Only available if requested during payment creation - The QR code that can be scanned by the mobile
/// Only available if requested during payment creation - The QR code that can be scanned by the mobile
/// Bancontact application. This enables the desktop to mobile feature.
/// </summary>
public QrCode? QrCode { get; set; }

/// <summary>
/// Only available if the payment is completed – The consumer’s bank account. This may be an IBAN, or it may be a domestic account number.
/// </summary>
Expand All @@ -41,10 +41,10 @@ public record BancontactPaymentResponseDetails {
/// Only available if the payment is completed – The consumer’s bank’s BIC / SWIFT code.
/// </summary>
public string? ConsumerBic { get; set; }

/// <summary>
/// The reason why the payment did not succeed. Only available when there's a reason known.
/// </summary>
public string? FailureReason { get; set; }
}
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using Mollie.Api.Models.Url;
using Newtonsoft.Json;

namespace Mollie.Api.Models.Payment.Response.Specific {
namespace Mollie.Api.Models.Payment.Response.PaymentSpecificParameters {
public record BankTransferPaymentResponse : PaymentResponse {
public required BankTransferPaymentResponseDetails Details { get; init; }

Expand Down Expand Up @@ -51,7 +51,7 @@ public record BankTransferPaymentResponseDetails {
public string? ConsumerBic { get; set; }

/// <summary>
/// Only available if filled out in the API or by the consumer � The email address which the consumer asked the payment
/// Only available if filled out in the API or by the consumer � The email address which the consumer asked the payment
/// instructions to be sent to.
/// </summary>
public string? BillingEmail { get; set; }
Expand All @@ -69,9 +69,9 @@ public record BankTransferPaymentResponseLinks : PaymentResponseLinks {
public required UrlLink Status { get; init; }

/// <summary>
/// A link to a hosted payment page where your customer can finish the payment using an alternative payment method also
/// A link to a hosted payment page where your customer can finish the payment using an alternative payment method also
/// activated on your website profile.
/// </summary>
public required UrlLink PayOnline { get; init; }
}
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Response.Specific {
namespace Mollie.Api.Models.Payment.Response.PaymentSpecificParameters {
public record BelfiusPaymentResponse : PaymentResponse {
public required BelfiusPaymentResponseDetails Details { get; init; }
}
Expand All @@ -19,4 +19,4 @@ public record BelfiusPaymentResponseDetails {
/// </summary>
public string? ConsumerBic { get; set; }
}
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Response {
namespace Mollie.Api.Models.Payment.Response.PaymentSpecificParameters {
public record CreditCardPaymentResponse : PaymentResponse {
/// <summary>
/// An object with credit card details.
Expand All @@ -18,13 +18,13 @@ public record CreditCardPaymentResponseDetails {
public string? CardNumber { get; set; }

/// <summary>
/// Only available if the payment has been completed - Unique alphanumeric representation of card, usable for identifying
/// Only available if the payment has been completed - Unique alphanumeric representation of card, usable for identifying
/// returning customers.
/// </summary>
public string? CardFingerprint { get; set; }

/// <summary>
/// Not always available. – The card's target audience. See the Mollie.Api.Models.Payment.Response.CreditCardAudience
/// Not always available. – The card's target audience. See the Mollie.Api.Models.Payment.Response.CreditCardAudience
/// class for a full list of known values
/// </summary>
public string? CardAudience { get; set; }
Expand All @@ -41,20 +41,20 @@ public record CreditCardPaymentResponseDetails {
public string? CardCountryCode { get; set; }

/// <summary>
/// Only available if the payment succeeded. – The payment's security type. See the
/// Only available if the payment succeeded. – The payment's security type. See the
/// Mollie.Api.Models.Payment.Response.CreditCardSecurity class for a full list of known values
/// </summary>
public string? CardSecurity { get; set; }

/// <summary>
/// Only available if the payment succeeded. – The fee region for the payment. See your credit card addendum for
/// details. intra-eu for consumer cards from the EU, and other for all other cards. See the
/// details. intra-eu for consumer cards from the EU, and other for all other cards. See the
/// Mollie.Api.Models.Payment.Response.CreditCardFeeRegion class for a full list of known values
/// </summary>
public string? FeeRegion { get; set; }

/// <summary>
/// Only available for failed payments. Contains a failure reason code. See the
/// Only available for failed payments. Contains a failure reason code. See the
/// Mollie.Api.Models.Payment.Response.CreditCardFailureReason class for a full list of known values
/// </summary>
public string? FailureReason { get; set; }
Expand Down Expand Up @@ -87,7 +87,7 @@ public static class CreditCardSecurity {
}

/// <summary>
/// Only available if the payment has been completed – The fee region for the payment: intra-eu for consumer cards from the EU, and
/// Only available if the payment has been completed – The fee region for the payment: intra-eu for consumer cards from the EU, and
/// other for all other cards.
/// </summary>
public static class CreditCardFeeRegion {
Expand Down Expand Up @@ -124,7 +124,7 @@ public static class CreditCardFailureReason {

/// <summary>
/// The card's label. Note that not all labels can be acquired through Mollie.
/// </summary>
/// </summary>
public static class CreditCardLabel {
public const string AmericanExpress = "American Express";
public const string CartaSi = "Carta si";
Expand All @@ -139,4 +139,4 @@ public static class CreditCardLabel {
public const string Unionpay = nameof(Unionpay);
public const string Visa = nameof(Visa);
}
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Response {
namespace Mollie.Api.Models.Payment.Response.PaymentSpecificParameters {
public record EpsPaymentResponse : PaymentResponse {
/// <summary>
/// An object with the consumer bank account details.
Expand All @@ -22,4 +22,4 @@ public record EpsPaymentResponseDetails {
/// </summary>
public string? ConsumerBic { get; set; }
}
}
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using System.Collections.Generic;

namespace Mollie.Api.Models.Payment.Response.Specific {
namespace Mollie.Api.Models.Payment.Response.PaymentSpecificParameters {
public record GiftcardPaymentResponse : PaymentResponse {
/// <summary>
/// An object with payment details.
Expand All @@ -10,7 +10,7 @@ public record GiftcardPaymentResponse : PaymentResponse {

public record GiftcardPaymentResponseDetails {
/// <summary>
/// The voucher number, with the last four digits masked. When multiple gift cards are used, this is the first voucher
/// The voucher number, with the last four digits masked. When multiple gift cards are used, this is the first voucher
/// number. Example: 606436353088147****.
/// </summary>
public string? VoucherNumber { get; set; }
Expand All @@ -21,13 +21,13 @@ public record GiftcardPaymentResponseDetails {
public List<Giftcard>? Giftcards { get; set; }

/// <summary>
/// Only available if another payment method was used to pay the remainder amount – The amount that was paid with
/// Only available if another payment method was used to pay the remainder amount – The amount that was paid with
/// another payment method for the remainder amount.
/// </summary>
public Amount? RemainderAmount { get; set; }

/// <summary>
/// Only available if another payment method was used to pay the remainder amount – The payment method that was used to
/// Only available if another payment method was used to pay the remainder amount – The payment method that was used to
/// pay the remainder amount.
/// </summary>
public string? RemainderMethod { get; set; }
Expand All @@ -49,4 +49,4 @@ public record Giftcard {
/// </summary>
public required string VoucherNumber { get; init; }
}
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Response {
namespace Mollie.Api.Models.Payment.Response.PaymentSpecificParameters {
public record GiropayPaymentResponse : PaymentResponse {
/// <summary>
/// An object with the consumer bank account details.
Expand All @@ -22,4 +22,4 @@ public record GiropayPaymentResponseDetails {
/// </summary>
public string? ConsumerBic { get; set; }
}
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Response {
namespace Mollie.Api.Models.Payment.Response.PaymentSpecificParameters {
public record IdealPaymentResponse : PaymentResponse {
/// <summary>
/// An object with the consumer bank account details.
Expand Down Expand Up @@ -27,4 +27,4 @@ public record IdealPaymentResponseDetails {
/// </summary>
public QrCode? QrCode { get; set; }
}
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Response.Specific {
namespace Mollie.Api.Models.Payment.Response.PaymentSpecificParameters {
public record IngHomePayPaymentResponse : PaymentResponse {
/// <summary>
/// An object with payment details.
Expand All @@ -22,4 +22,4 @@ public record IngHomePayPaymentResponseDetails {
/// </summary>
public string? ConsumerBic { get; set; }
}
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Response.Specific {
namespace Mollie.Api.Models.Payment.Response.PaymentSpecificParameters {
public record KbcPaymentResponse : PaymentResponse {
public required KbcPaymentResponseDetails Details { get; init; }
}
Expand All @@ -19,4 +19,4 @@ public record KbcPaymentResponseDetails {
/// </summary>
public string? ConsumerBic { get; set; }
}
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Response {
namespace Mollie.Api.Models.Payment.Response.PaymentSpecificParameters {
public record PayPalPaymentResponse : PaymentResponse {
public PayPalPaymentResponseDetails? Details { get; set; }
}
Expand All @@ -25,7 +25,7 @@ public record PayPalPaymentResponseDetails {
public string? PaypalPayerId { get; set; }

/// <summary>
/// Indicates if the payment is eligible for PayPal's Seller Protection. This parameter is omitted if we did not
/// Indicates if the payment is eligible for PayPal's Seller Protection. This parameter is omitted if we did not
/// received the information from PayPal. See the Mollie.Api.Models.Payment.Response.PayPalSellerProtection class
/// for a full list of known values.
/// </summary>
Expand All @@ -35,9 +35,9 @@ public record PayPalPaymentResponseDetails {
/// The shipping address details.
/// </summary>
public AddressObject? ShippingAddress { get; set; }

/// <summary>
/// The amount of fee PayPal will charge for this transaction. This field is omitted if PayPal will not charge a fee
/// The amount of fee PayPal will charge for this transaction. This field is omitted if PayPal will not charge a fee
/// for this transaction.
/// </summary>
public Amount? PaypalFee { get; set; }
Expand All @@ -52,4 +52,4 @@ public static class PayPalSellerProtection {
public const string None = nameof(None);
public const string ActiveFraudControlUnauthPremiumEligible = "Active Fraud Control - Unauth Premium Eligible";
}
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Mollie.Api.Models.Payment.Response {
namespace Mollie.Api.Models.Payment.Response.PaymentSpecificParameters {
public record PaySafeCardPaymentResponse : PaymentResponse {
public required PaySafeCardPaymentResponseDetails Details { get; init; }
}
Expand All @@ -9,4 +9,4 @@ public record PaySafeCardPaymentResponseDetails {
/// </summary>
public string? CustomerReference { get; set; }
}
}
}
Loading

0 comments on commit ec2e6f9

Please sign in to comment.