Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapting the library to be used with API #280

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alustau
Copy link

@alustau alustau commented Apr 26, 2017

I just refactored some duplicated codes, and allowing the library save user_id when It's using by API...

To save a user_id, just add a parameter in your request called session_user_id... I know it is not good solution, but It's helping me a lot...

@ellej16
Copy link

ellej16 commented Apr 28, 2017

Just throwing this out there, why not just user_id instead of session_user_id? or even have the dev specify the parameter name (either via config or env)?

Great idea btw!

@alustau
Copy link
Author

alustau commented Apr 28, 2017

First all, thanks for replied me
I used session_user_id, because In some request to API someone can use a user_id to another thing, but I liked the idea about put it on config, so this way you can config your own variable name...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants