Remove hydra use query api #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrit110
added
bug
Codecov Report
@@ Coverage Diff @@
## main #491 +/- ##
==========================================
- Coverage 64.77% 64.71% -0.07%
==========================================
Files 99 99
Lines 9907 9873 -34
==========================================
- Hits 6417 6389 -28
+ Misses 3490 3484 -6
|
hoxell
approved these changes
Oct 8, 2023
Eh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type ([Feature | Fix | Documentation | Test])
Fix
Short Description
Use of hydra to load configuration and then override for database is not ideal in the API itself since it obscures what parameters are being passed around, and you would need to go and look at the configs. The hydra config can be introduced during workflow orchestration when some higher level program accepts config files and calls the APIs.
Also added URL encoding of the password to allow for characters like
@to be used without issues.Tests Added
Just modified existing ones.