-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create __init__.py #490
Create __init__.py #490
Conversation
The following code fails because 'tasks' will be loaded as 'tasks.py' file instead of the directory containing 'mortalitiy_prediction'. from cyclops.tasks.mortality_prediction import MortalityPredictionTask Signed-off-by: Adibvafa Fallahpour <[email protected]>
Thanks for your contribution! :) Could you share how you set up your environment? Was it through the pip install? I ask because running |
Yeah adding to @fcogidi, good catch. In the development env, poetry installs the BTW, we could even import the task classes in the init file so that you can do from cyclops.tasks.mortality_prediction import MortalityPredictionTask
from cyclops.tasks.cxr_classification import CXRClassificationTask |
Yes, my environment is not a development environment, it's merely a conda env and I installed cyclops with pip. |
Added new imports. Signed-off-by: Adibvafa Fallahpour <[email protected]>
That's a great idea! Just committed the changes you mentioned. |
@Adibvafa, should now be fixed in |
Awesome! Thank you so much! |
PR Type ([Feature | Fix | Documentation | Test])
Fix the issue of importing MortalityPredictionTask. Source of the bug is when replication the tutorial below: https://vectorinstitute.github.io/cyclops/api/tutorials/kaggle/heart_failure_prediction.html
Short Description
The following code fails because 'tasks' will be loaded as 'tasks.py' file instead of the directory containing 'mortalitiy_prediction'.
from cyclops.tasks.mortality_prediction import MortalityPredictionTask
Tests Added
Added init file to fix the issue.