Start training button #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… endpoint failing. Force refetch data after start training to reflect status update of job
…nt of the call to change the status to in progress. Add initial ui test for start job button.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
florist/api/routes/server/job.py
Outdated
| await job_in_db.set_status(status, request.app.database) | ||
| return JSONResponse(content={"status": "success"}) | ||
| except AssertionError as assertion_e: | ||
| return JSONResponse(content={"error": str(assertion_e)}, status_code=400) |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 91.96% 91.96% -0.01%
==========================================
Files 21 21
Lines 1270 1331 +61
Branches 73 50 -23
==========================================
+ Hits 1168 1224 +56
- Misses 102 107 +5 ☔ View full report in Codecov by Sentry. |
lotif
requested changes
Jun 25, 2024
lotif
requested changes
Jun 26, 2024
|
I am adding a "details" button as well, and I'm thinking if it wouldn't be cleaner to have buttons with just icons instead: 
If you like that version, it's easy to do: <button
data-testid={`start-training-button-${rowId}`}
onClick={onClick}
className="btn btn-primary btn-sm mb-0"
title="Start"
>
<i className="material-icons text-sm">play_circle_outline</i>
</button> |
…icon instead of 'start' for button
lotif
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[Feature | Fix | Documentation | Other ]
Short Description
Clickup Ticket(s): Start Training Button
PR that adds a start button to Not Started jobs. When clicked, a call is made to the start training endpoint. During training, the job status is temporarily changed to In Progress. If the job completes successfully, the job status is changed to Finished Successfully else it is changed to Finished With Error. Here is an example of what the UI looks like with this addition:
Tests Added
Added UI tests for the start button to make sure it only appears when appropriate and behaves as expected when clicked.