Change status #66
Merged
Change status #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lotif
requested changes
Jun 19, 2024
| async def test_change_job_status_failure_in_set_status(mock_find_by_id: Mock) -> None: | ||
| mock_job = Mock() | ||
| mock_job.set_status = AsyncMock() | ||
| mock_job.set_status.side_effect = AssertionError("Test Error") |
There was a problem hiding this comment.
Raising an assertion error here is not 100% accurate. It would be better if you could raise a generic exception and also add an except Exception as e: in the code to catch a generic exception, which would return status 500 indicating a server error.
| await job_in_db.set_status(status, request.app.database) | ||
| return JSONResponse(content={"status": "success"}) | ||
| except AssertionError as assertion_e: | ||
| return JSONResponse(content={"error": str(assertion_e)}, status_code=400) |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
lotif
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[Feature | Fix | Documentation | Other ]
Short Description
Clickup Ticket(s): Change Job Status Endpoint
Small PR to add an endpoint to change the status of jobs.
Tests Added
A few tests to check if we are returning the right responses for both successful and unsuccessful requests.