Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make client's python FastAPI connect endpoint #5

Merged
merged 24 commits into from
Feb 22, 2024
Merged

Make client's python FastAPI connect endpoint #5

merged 24 commits into from
Feb 22, 2024

Conversation

lotif
Copy link
Collaborator

@lotif lotif commented Feb 15, 2024

PR Type

Feature

Short Description

Clickup Ticket(s): https://app.clickup.com/t/8687bx007

  • Adding the client FastAPI file
  • Adding a simple "connect" endpoint
  • Adding tests
  • Adding github workflow to run the tests (copied from FL4Health)
  • Adding info on how to start the client on README.md

Tests Added

tests.app.test_client::test_connect

Base automatically changed from nextjs-template to main February 15, 2024 20:09
# Conflicts:
#	florist/api/index.py
#	florist/app/client_imports.tsx
#	florist/app/layout.tsx
#	florist/app/page.tsx
#	florist/app/sidebar.tsx
@lotif lotif marked this pull request as ready for review February 15, 2024 20:11
@lotif lotif requested a review from fatemetkl February 15, 2024 21:35
Copy link
Collaborator

@jewelltaylor jewelltaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lotif lotif merged commit 125d70e into main Feb 22, 2024
2 checks passed
@lotif lotif deleted the client-connect branch February 22, 2024 17:23
@lotif lotif mentioned this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants