Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more small fixes #48

Merged
merged 1 commit into from
May 28, 2024
Merged

Some more small fixes #48

merged 1 commit into from
May 28, 2024

Conversation

lotif
Copy link
Collaborator

@lotif lotif commented May 24, 2024

PR Type

Fix

Short Description

Clickup Ticket(s): NA

Adding some more small fixes here in order to avoid polluting my next PR:

  • Adding verbose: true on codecov to help debug failure runs
  • Adding the .swc folder to gitignore
  • Removing the trailing slash on /api/server/job route which was causing problems with Next.js' redirect

Tests Added

NA

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.74%. Comparing base (8483f52) to head (bd9f1a9).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #48       +/-   ##
===========================================
- Coverage   91.58%   78.74%   -12.84%     
===========================================
  Files          20       20               
  Lines         701      701               
  Branches       11       11               
===========================================
- Hits          642      552       -90     
- Misses         59      149       +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jewelltaylor jewelltaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lotif lotif merged commit 0d66f35 into main May 28, 2024
8 checks passed
@lotif lotif deleted the small-fixes branch May 28, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants