Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check status server #20

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Check status server #20

merged 2 commits into from
Apr 23, 2024

Conversation

jewelltaylor
Copy link
Collaborator

PR Type

[Feature | Fix | Documentation | Other ]

Short Description

Clickup Ticket(s): Make the server's "check status" endpoint

Add server endpoint that returns the value at key server_uuid if it exists.

Tests Added

  • Test valid server uuid, test non existent server_uuid and handling fail exception.

@jewelltaylor jewelltaylor requested review from lotif and emersodb April 17, 2024 16:37
lotif
lotif approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@lotif lotif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question.

florist/api/client.py Show resolved Hide resolved
@jewelltaylor jewelltaylor merged commit 8e5ee52 into main Apr 23, 2024
4 checks passed
@jewelltaylor jewelltaylor deleted the check-status-server branch April 23, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lotif lotif lotif approved these changes

@emersodb emersodb Awaiting requested review from emersodb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jewelltaylor @lotif