Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes... #108

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Some changes... #108

merged 4 commits into from
Oct 18, 2024

Conversation

lotif
Copy link
Collaborator

@lotif lotif commented Oct 17, 2024

PR Type

Fix

Short Description

Clickup Ticket(s): NA

Code checks github action uses the pre commit to do the actual code checks. However, there is a lot of flakiness that happens only on github actions and not locally. Here I am making some changes in order to remove the flakiness and also doing some code cleanup.

Tests Added

NA

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.94%. Comparing base (9199bfb) to head (78df45e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files          23       23           
  Lines        1981     1981           
  Branches      105      163   +58     
=======================================
  Hits         1861     1861           
  Misses        120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lotif lotif marked this pull request as ready for review October 18, 2024 14:27
Copy link
Collaborator

@emersodb emersodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

@lotif lotif merged commit dcaf48d into main Oct 18, 2024
8 checks passed
@lotif lotif deleted the try-fix-flakiness branch October 18, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants