Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly listen to client updates #106

Merged
merged 9 commits into from
Nov 1, 2024
Merged

Explicitly listen to client updates #106

merged 9 commits into from
Nov 1, 2024

Conversation

lotif
Copy link
Collaborator

@lotif lotif commented Oct 16, 2024

PR Type

Fix

Short Description

Clickup Ticket(s): https://app.clickup.com/t/868a6rfpy

Replacing the old approach of updating client metrics together with server metrics update for an active listener to each one of the clients' redis, similar to the one for the server.

This will ensure the metrics are always up to date for clients and also the client metrics updates are not dependent on server updates and can be ultimately visualized independently from server metrics updates in the UI.

Tests Added

Unit tests for the listener added
Integration tests for set_client_metrics

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.00%. Comparing base (9199bfb) to head (a577d0c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   93.94%   94.00%   +0.06%     
==========================================
  Files          23       23              
  Lines        1981     2002      +21     
  Branches      105      163      +58     
==========================================
+ Hits         1861     1882      +21     
  Misses        120      120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jewelltaylor jewelltaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in the code look good to me and everything work as expected when testing via the UI!

@lotif lotif merged commit 2046e5c into main Nov 1, 2024
8 checks passed
@lotif lotif deleted the client-update-metrics branch November 1, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants