Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply aieng-template to project #1

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Apply aieng-template to project #1

merged 4 commits into from
Feb 6, 2024

Conversation

lotif
Copy link
Collaborator

@lotif lotif commented Feb 1, 2024

PR Type

Other

Short Description

Clickup Ticket(s): https://app.clickup.com/t/86877gvr9

Applying https://github.com/VectorInstitute/aieng-template to this project

Tests Added

NA

- name: Checkout code
uses: actions/checkout@v3

- name: Set up Python 3.8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't really matter now but should we update this to a Python 3.9 - 3.11 to stay consistent with the pyproject.toml?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it does! thanks for catching it :) I upgraded it to 3.9 which is the same as FL4Health.

Copy link
Collaborator

@jewelltaylor jewelltaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small comment, everything looks good to me!

@lotif lotif merged commit 405705e into main Feb 6, 2024
1 check passed
@lotif lotif deleted the apply-aieng-template branch February 6, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants