Skip to content

Commit

Permalink
Last changes to try to fix flakiness on code checks/yarn lint (#111)
Browse files Browse the repository at this point in the history
* Moving tsconfig to the right path
* Fixing some yaml files
* Making static code checks run when tsx files are modified
* Adding a manual hook to run static code check so we can better debug
* Enabling verbose pre commit check runs to better debug the flakiness
  • Loading branch information
lotif authored Oct 23, 2024
1 parent 941d681 commit d6a5d2f
Show file tree
Hide file tree
Showing 6 changed files with 29 additions and 13 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/docs_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ on:
- main
paths:
- .pre-commit-config.yaml
- .github/workflows/static_code_checks.yml
- .github/workflows/static_code_checks.yaml
- .github/workflows/docs_build.yml
- .github/workflows/docs_deploy.yml
- .github/workflows/tests.yml
- .github/workflows/unit_tests.yaml
- .github/workflows/integration_tests.yaml
- '**.py'
- '**.ipynb'
- poetry.lock
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/integration_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ on:
- main
paths:
- .pre-commit-config.yaml
- .github/workflows/static_code_checks.yml
- .github/workflows/static_code_checks.yaml
- .github/workflows/docs_build.yml
- .github/workflows/docs_deploy.yml
- .github/workflows/tests.yml
- .github/workflows/unit_tests.yaml
- .github/workflows/integration_tests.yaml
- '**.py'
- '**.ipynb'
- poetry.lock
Expand All @@ -24,7 +25,7 @@ on:
- .github/workflows/static_code_checks.yml
- .github/workflows/docs_build.yml
- .github/workflows/docs_deploy.yml
- .github/workflows/tests.yml
- .github/workflows/integration_tests.yml
- '**.py'
- '**.ipynb'
- poetry.lock
Expand Down
19 changes: 16 additions & 3 deletions .github/workflows/static_code_checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,34 @@ on:
- main
paths:
- .pre-commit-config.yaml
- .github/workflows/code_checks.yml
- .github/workflows/static_code_checks.yaml
- '**.py'
- poetry.lock
- pyproject.toml
- '**.ipynb'
- '**.tsx'
pull_request:
branches:
- main
paths:
- .pre-commit-config.yaml
- .github/workflows/code_checks.yml
- .github/workflows/static_code_checks.yaml
- '**.py'
- poetry.lock
- pyproject.toml
- '**.ipynb'
- '**.tsx'
workflow_dispatch:
inputs:
logLevel:
description: 'Log level'
required: true
default: 'debug'
type: choice
options:
- info
- warning
- debug

jobs:
run-code-check:
Expand All @@ -44,7 +57,7 @@ jobs:
poetry env use '3.9'
source .venv/bin/activate
poetry install --with test --all-extras
pre-commit run --all-files
pre-commit run --all-files --verbose
- name: pip-audit (gh-action-pip-audit)
uses: pypa/[email protected]
with:
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/unit_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ on:
- main
paths:
- .pre-commit-config.yaml
- .github/workflows/static_code_checks.yml
- .github/workflows/static_code_checks.yaml
- .github/workflows/docs_build.yml
- .github/workflows/docs_deploy.yml
- .github/workflows/tests.yml
- .github/workflows/unit_tests.yaml
- .github/workflows/integration_tests.yaml
- '**.py'
- '**.ipynb'
- poetry.lock
Expand All @@ -21,10 +22,11 @@ on:
- main
paths:
- .pre-commit-config.yaml
- .github/workflows/static_code_checks.yml
- .github/workflows/static_code_checks.yaml
- .github/workflows/docs_build.yml
- .github/workflows/docs_deploy.yml
- .github/workflows/tests.yml
- .github/workflows/unit_tests.yaml
- .github/workflows/integration_tests.yaml
- '**.py'
- '**.ipynb'
- poetry.lock
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ yarn-error.log*
# typescript
*.tsbuildinfo
next-env.d.ts
/florist/tsconfig.json

/metrics/
/logs/
Expand Down
File renamed without changes.

0 comments on commit d6a5d2f

Please sign in to comment.