Add list class method to JobStatus Enum. More informative error message.

florist/api/db/entities.py

@@ -22,6 +22,15 @@ class JobStatus(Enum):
     FINISHED_WITH_ERROR = "FINISHED_WITH_ERROR"
     FINISHED_SUCCESSFULLY = "FINISHED_SUCCESSFULLY"
 
+    @classmethod
+    def list(cls) -> List[str]:
+        """
+        List all the supported clients.
+
+        :return: (List[str]) a list of valid job statuses.
+        """
+        return [status.value for status in JobStatus]
+
 
 class ClientInfo(BaseModel):
     """Define the information of an FL client."""

florist/api/routes/server/job.py

@@ -63,8 +63,8 @@ async def list_jobs_with_status(status: JobStatus, request: Request) -> List[Dic
     status = jsonable_encoder(status)
 
     assert isinstance(status, str)
-    if status not in JobStatus._member_names_:
-        msg = f"status is not valid. status: {status}."
+    if status not in JobStatus.list():
+        msg = f"status {status} is not valid. Valid statuses: {JobStatus.list()}"
         raise HTTPException(status_code=400, detail=msg)
 
     job_db = request.app.database[JOB_DATABASE_NAME]

florist/tests/integration/api/routes/server/test_job.py

@@ -331,4 +331,5 @@ async def test_list_jobs_with_invalid_status(mock_request) -> None:
         await list_jobs_with_status("NON_EXISTENT_STATUS", mock_request)
 
     assert exception_info.value.status_code == 400
-    assert "status is not valid. status: NON_EXISTENT_STATUS" in exception_info.value.detail
+    exc_str = f"status NON_EXISTENT_STATUS is not valid. Valid statuses: {JobStatus.list()}"
+    assert exc_str in exception_info.value.detail