Custom nnunet trainer #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersodb
approved these changes
Nov 25, 2024
| @@ -141,6 +143,10 @@ def __init__( | |||
| provided. Defaults to None. | |||
| reporters (Sequence[BaseReporter], optional): A sequence of FL4Health | |||
| reporters which the client should send data to. | |||
| nnunet_trainer_class (Type[nnUNetTrainer]): A nnUNetTrainer constructor. | |||
There was a problem hiding this comment.
Maybe add a quick note here and on the server-side that the training classes have to match each other (client and server trainers should be the same)?
| @@ -34,6 +34,7 @@ scikit-learn = "1.5.0" # Pin as it was causing issues with nnunet | |||
| # Problematic grpcio versions cause issues, should be fixed in next flwr update | |||
| # See https://github.com/adap/flower/pull/3853 | |||
| # https://github.com/grpc/grpc/issues/37162 | |||
| tornado = ">=6.4.2" | |||
There was a problem hiding this comment.
Out of curiosity, why did this need upgrading?
There was a problem hiding this comment.
pip audit flags 6.4.1 so had to upgrade to 6.4.2 or higher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[Feature | Fix | Documentation | Other ]
Short Description
Small PR to add the ability to specify a custom nnunet trainer class.