Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercasing torch device variables throughout library when not global #279

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

emersodb
Copy link
Collaborator

@emersodb emersodb commented Nov 7, 2024

PR Type

Other

Short Description

Clickup Ticket(s): N/A

Just a small syntax cleanup PR that lowercases the torch device variable in the library throughout when it isn't being used as a global variable. This is a bit more standard practice.

Tests Added

N/A. This is strictly a name change. So shouldn't change functionality.

Copy link
Collaborator

@jewelltaylor jewelltaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from dbe/add_feddgga_compatibility to main November 11, 2024 14:59
@emersodb emersodb merged commit 3957e39 into main Nov 11, 2024
6 checks passed
@emersodb emersodb deleted the dbe/lower_case_device_everywhere branch November 11, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants