Updating the FLamby installation instructions to reflect some changes on their end. #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Looks like FLamby upgraded their library this summer. So the install process appears to be smoother again.
… change that needs to be done for FLamby to run correctly after installation.
emersodb
requested review from
lotif,
fatemetkl,
jewelltaylor,
scarere and
sanaAyrml
emersodb
commented
Oct 31, 2024
| ``` | ||
| __NOTE__: We avoid installing Fed-KITS2019, as it requires a fairly old version on nnUnet, which we no longer support in our library. | ||
|
|
||
| In addition, you'll have to edit the code for `FedIXITiny` in `flamby/datasets/fed_ixi/datasets.py` replacing the following |
There was a problem hiding this comment.
The work around below is required in order to run any of the experiments, since our dataset processing files handle all of the dataset preprocessing for the datasets of interest. It's pretty straightforward to do since we install the library as "editable" (i.e. the -e) option.
There was a problem hiding this comment.
FLamby corrected a few things with MonAI compatibility but apparently left this one behind.
emersodb
commented
Oct 31, 2024
| @@ -95,7 +95,7 @@ def validate(self, val_metric_mngr: MetricManager) -> None: | |||
| for input, target in self.val_loader: | |||
| input, target = input.to(self.device), target.to(self.device) | |||
|
|
|||
| preds = self.model(input) | |||
| preds = {"predictions": self.model(input)} | |||
There was a problem hiding this comment.
Small fix that must have been missed when we migrated to dictionaries for predictions at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Other
Short Description
Clickup Ticket(s): Link
This PR drops the FLamby requirements file in favor of moving back to installing the library from the FLamby repository. I tested running several of our FLamby experiments for (FedHeartDisease, Fed-IXI, and FedISIC2019). There was a small bug fix that needed to be applied to the single node training code, but other than that the experiments ran as expected.
Tests Added
No specific tests. However, I tested the fixes etc. by running a sampling of the FLamby experimental code.