Vault ghoul ban 2 #687
Merged
Vault ghoul ban 2 #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drastic measures. Directly under requirements.
VMSolidus
pushed a commit
to VMSolidus/nuclear-14
that referenced
this pull request
Nov 15, 2024
# Description
I have made this originally for N14 as there was a heavy need for junk
items to be list instead of a hash. It created a few issues where you
were unable to put down 2 pieces of steel without making a new defined
entity which spawns a stack of 2.
I thought this was quite annoying so I decided to instead make it into a
`EntitySpawnEntry` from a `string` which would also give it options of
`amount` `prob` `maxAmount` and `orGroup` which would definitely aid in
the scrapping needs there as you could randomize the refined amounts.
I believe this could be useful upstream. As well as cleaning up code
which is more modifiable than before.
The new example of how it can be typed in yaml is also simpler in my
opinion as it is self-explanatory and used in various places like
StorageFill contents for one.
```YAML
- type: WelderRefinable
refineResult:
- id: SheetGlass1
amount: 1
maxAmount: 2
prob: 0.5
orGroup: Glass
```
---
:cl:
refactor: Refactors WelderRefinableComponent.cs and RefiningSystem.cs
tweak: Tweaked the formatting for WelderRefinable refineResult to use
EntitySpawnEntry format
VMSolidus
pushed a commit
to VMSolidus/nuclear-14
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another formatting test against the Linter, my archnemesis.
Description.
Adjusted the parsing on the "-".
# ChangelogCL
🆑
change: adjusted "-"
me: praying 👀