Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio station #674

Merged
merged 11 commits into from
Nov 12, 2024
Merged

Radio station #674

merged 11 commits into from
Nov 12, 2024

Conversation

bryan-hub
Copy link
Contributor

Description

Added files and edits to create a working radio station. Includes new channel, PBS, and one way tabletop radios.

Copy link
Contributor

github-actions bot commented Nov 10, 2024

RSI Diff Bot; head commit 5410171 merging into 768abca
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Nuclear14/Structures/Misc/radiostation/microphones.rsi

State Old New Status
base Added
off Added
on Added

Resources/Textures/_Nuclear14/Structures/Misc/radiostation/radioonair.rsi

State Old New Status
base Added
off Added
on Added

Resources/Textures/_Nuclear14/Structures/Misc/radiostation/standmicrophones.rsi

State Old New Status
base Added
off Added
on Added

Resources/Textures/_Nuclear14/Structures/Misc/radiostation/tableradio.rsi

State Old New Status
base Added
icon Added
off Added
on Added
radioon Added

Edit: diff updated after 5410171

Copy link
Contributor

@Partmedia Partmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please see review comments inline.

@bryan-hub
Copy link
Contributor Author

Is there anything else needed before merge?

@Partmedia
Copy link
Contributor

A few more comments:

  • The standing microphone does not default to the broadcast frequency. Not sure if this was intended or not.
  • An exception shows up on the server when you attempt to turn on the (non-existent) speaker button on the radio UI:
    [ERRO] system.radio_device: Can't resolve "Content.Server.Radio.Components.RadioSpeakerComponent" on entity radio microphone (43074/n43074, RadioDJMicrophone)!
     at Content.Server.Radio.EntitySystems.RadioDeviceSystem.SetSpeakerEnabled(EntityUid uid, EntityUid user, Boolean enabled, Boolean quiet, RadioSpeakerComponent component) in Content.Server/Radio/EntitySystems/RadioDeviceSystem.cs:line 158
    
  • An FTL string is missing for the PBS channel chat-radio-pbs (see screenshot)
  • The GUI title still shows up as "Handheld radio" (see screenshot)

image

Other than that, this seems to work.

Peptide90 pushed a commit that referenced this pull request Nov 11, 2024
# Description

Adds a new trait which plants can mutate to have. 
It teleports both the slippee and the produce to a random location
within a radius determined by how potent the produce is.
Inert unless the plant also has the slippery trait. 

~~Probably very stinky code considering this is my first time dealing
with c#.~~

---
<details><summary><h1>Media</h1></summary>
<p>



https://github.com/user-attachments/assets/cd22756d-ea5e-4a30-8043-c991549c9019



</p>
</details>

---

# Changelog

:cl:
- add: Added Bluespace Slips, a plant trait that teleports you randomly
if you slip.
Peptide90 pushed a commit that referenced this pull request Nov 11, 2024
@bryan-hub
Copy link
Contributor Author

Added the 1667 frequency to the standing mics, tested. Removed UI from mic's all together. It is unnecessary since you no longer need to change the frequency or speaker. This way, if you click the mic, it enables it. This removes the error and the UI name, tested as well. Also, added pbs as Public Broadcast. Should hopefully address everything. Tested.

@Peptide90 Peptide90 merged commit b6ad103 into Vault-Overseers:master Nov 12, 2024
9 checks passed
@bryan-hub bryan-hub deleted the radio-station branch November 25, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants