Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Can opening too Dog Food + Added a special brand of dog food #314

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

MutantMan2040
Copy link
Contributor

Added Can opening to dog food, aswell added a new variant of it. The fog food now has three states, closed, open, and empty. It functions the same as canned peaches from upstream. the open sprite was fixed, as the top was bigger in the open sprite, than it was in the closed. a empty sprite was added aswell for the third state. 3 new sprites were added for the Dinki-Di Dog Food object, its a fun referance to another very popular Post Apocalyptic franchise.

Description

Description.


TODO

  • Task
  • Completed Task

Media

Added Can opening to dog food, aswell added a new variant of it. The fog food now has three states, closed, open, and empty. It functions the same as canned peaches from upstream. the open sprite was fixed, as the top was bigger in the open sprite, than it was in the closed. a empty sprite was added aswell for the third state. 3 new sprites were added for the Dinki-Di Dog Food object, its a fun referance to another very popular Post Apocalyptic franchise.
Copy link
Contributor

github-actions bot commented Jul 8, 2024

RSI Diff Bot; head commit 643170c merging into 6ac37de
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Nuclear14/Objects/Consumable/Food/pre-war.rsi

State Old New Status
dogfood_open Removed
dinki-Dis Added

Resources/Textures/_Nuclear14/Objects/Consumable/Food/dinkidi.rsi

State Old New Status
icon-open Added
icon Added
trash Added

Resources/Textures/_Nuclear14/Objects/Consumable/Food/dogfood.rsi

State Old New Status
icon-open Added
icon Added
trash Added

Edit: diff updated after 643170c

Copy link
Contributor

@BlueHNT BlueHNT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've forgotten to remove dogfood and dogfood_open from the meta.json in pre-war.rsi

I couldn't get to it since you haven't made changes so I made a pull in your fork.
MutantMan2040#1

@BlueHNT BlueHNT added the No C# For easier issues relating to YAML label Jul 9, 2024
@MutantMan2040
Copy link
Contributor Author

We fix, should be good to merge now

@Peptide90 Peptide90 merged commit 0561884 into Vault-Overseers:master Jul 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes: YML No C# For easier issues relating to YAML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants