Skip to content

Commit

Permalink
cleanup: add missing rss button & add margin only to the first child
Browse files Browse the repository at this point in the history
Till now, all buttons inside the card header were getting a margin of 30px, but that adds a lot of space not nessesary for other than the first button. So I've made the 30px marging only be added to the first child button of the card's header.

Sorry for the wall of text, but I wanted to explain exactly why I did this change.
  • Loading branch information
GabsEdits committed Aug 1, 2024
1 parent 60fa5a1 commit 86487f2
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
4 changes: 2 additions & 2 deletions public/assets/css/components/card.css
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@
font-size: 38px;
}

.card.card--type-adv.card--type-adv--hz .card-header .btn {
.card.card--type-adv.card--type-adv--hz .card-header .btn:first-child {
margin-top: 30px;
}

Expand Down Expand Up @@ -362,4 +362,4 @@
font-size: 24px;
line-height: 1.35;
}
}
}
8 changes: 6 additions & 2 deletions src/views/download/DownloadOrchidStable.vue
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,12 @@
<h2>Subscribe to the Newsletter</h2>
<div class="btn btn--primary" @click="isNotMailNotChimpOpen = true">
<span class="mdi material-icons">email</span>
<span>Subscribe Now</span>
<span>Subscribe Now via Email</span>
</div>
<a class="btn btn--primary" href="//vanillaos.org/feed.xml">
<span class="mdi material-icons">newspaper</span>
<span>Subscribe via the RSS Feed</span>
</a>
</div>
<div class="card-content">
<div class="flexList">
Expand Down Expand Up @@ -111,4 +115,4 @@ export default defineComponent({
},
}
});
</script>
</script>

0 comments on commit 86487f2

Please sign in to comment.