Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow updating built-in package managers #406

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

jardon
Copy link
Member

@jardon jardon commented Oct 15, 2024

  • check for built-in and error
  • add english translation for error

Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation LGTM, initially if I recollect correctly we allowed editing the built-in package managers so that users can edit the arguments as per their requirement, IG they can still duplicate and edit it now or open a PR to the custom apx stacks repo (so it benefits all users).

@kbdharun
Copy link
Member

@mirkobrombin This branch is upto date but still it is waiting for sonar action, can you go to https://github.com/Vanilla-OS/apx/settings and branch protection rules then remove the requirement from there.

@mirkobrombin
Copy link
Member

We dropped that idea some time ago, they should make they own package managers with different names

- check for built-in and error
- add english translation for error
@jardon jardon merged commit 9c10e8c into Vanilla-OS:main Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants