Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dyeing Finisher #576

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

NPC1314
Copy link

@NPC1314 NPC1314 commented Jan 24, 2025

About The Pull Request

Final step of the dye update.

  • Bins now destructibe, can´t hold weapons. Animated when destroyed. No more easy abuse with cheap indestructibe bins.
  • Dye bins visually show when full, updated sounds. Now made by adding dyes to a bin instead of a unique separate type of bin recipe, cleaner & better. The defines for the color range werent updated, sorted.
  • Cheap dyes can be made by anyone by adding 2x jacksberries or swampweed in any combo to ash. Use on bin for dye bin.
  • Luxury dyes spawn with the tailor & can be imported by the merchant
  • Tailor spawns with a book with a few practical advice for new players trying to learn tailoring & dyeing
  • Fancy hats with feathers 1 cheaper cloth but now needs a feather to make
  • Courtier hat now craftable. The craftable cloth chaperone set to the dyable cloth version instead of the brown one.
  • Couple of the silk recipe names fixed so theyll display in the right order.
  • Couple beggar clothing that had slipped through got the correct color range

Animation when destroyed was too problematic so just skipping that I guess.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant