-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-write webauth implementation for steam backend changes #453
base: master
Are you sure you want to change the base?
Conversation
@aUniqueUser I gave a try with your code but it does not work. I tried this:
but I get this exception:
|
Forget about my previous answer, you changed a bit the behavior of the login method so my legacy code failed but after a deeper look into your code it works fine using login with username and password attributes
works fine, thank you very much for your help. |
Yea before final merge I will need to correct it to work better with legacy code, good to see it working though 👍 |
'platform_type': '2', | ||
'persistence': '1', | ||
'website_id': 'Community' | ||
}, 'IAuthentication', 'BeginAuthSessionViaCredentials', 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I use the steam authenticator app I added support for it by adding the following lines here at line 144:
if "allowed_confirmations" in r['response']:
print("Respond to steam guard within 10 seconds")
sleep(10)
and of course adding sleep
to the import at row 58.
If you reply to the authentication before the _pollLoginStatus
the login will continue as normal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the info, ill full implement when i get some time and will add email auth aswell. Need to figure out what 'guard_data' is in here https://steamapi.xpaw.me/#IAuthenticationService/BeginAuthSessionViaCredentials
Has anyone figured out how to add email authentication to this. |
Yeah. I will write some staff into codebase and add pull request (about 1 day) mayble sooner, but it's 3 AM for me |
No worries, take your time. |
I added
I added some changes, and will add MUCH more later. you can check them out in another PR: #454 |
login/dologin/ was borked by valve, pr addresses issue by using the new login system
todo: