Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Explore Page AppBar with Home Page Style #195

Merged

Conversation

VITianLalit
Copy link
Contributor

@VITianLalit VITianLalit commented Jun 30, 2024

This pull request modifies the ExplorePage to ensure that its AppBar is consistent with the AppBar used on the Home Page. Specifically, the scrollable SliverAppBar was replaced with a fixed AppBar.

  • Changes Made
    Removed SliverAppBar: The SliverAppBar was removed from the ExplorePage.
    Added Fixed AppBar: A standard AppBar was added to ensure it remains fixed while the page content scrolls.
    Updated Body Content: The main content was encapsulated in a SliverList to maintain the scrollable content area without affecting the fixed AppBar.
explore_page.mp4

@sapatevaibhav ,Please review these changes and merge them into the master branch if everything looks good. Thank you!
fixes issue: Make explore page better #193

@sapatevaibhav
Copy link
Member

Screenshot from 2024-06-30 19-38-23
remove option 1 (mentioned in screenshot) as it is same as 3rd one as well make no 2 similar to others like 3 as it doesn't look proper.

@VITianLalit
Copy link
Contributor Author

@sapatevaibhav , oky....

@VITianLalit
Copy link
Contributor Author

@sapatevaibhav , I have made the changes in the explore_page_better branch, kindly review,

image

it is working fine now...

@VITianLalit
Copy link
Contributor Author

fixes issue: Make explore page better #193

@VITianLalit
Copy link
Contributor Author

VITianLalit commented Jul 1, 2024

@sapatevaibhav , Please, let me know, why are you not merging this pull request, Is there any need to do some more changes???

@sapatevaibhav
Copy link
Member

I'll merge it tonight after testing on my device as I'm busy with some other stuff that is being late😕.
I hope you will understand.

@VITianLalit
Copy link
Contributor Author

Okay, Thanks for informing....

@sapatevaibhav sapatevaibhav merged commit 003750d into VaibhavCodeClub:master Jul 2, 2024
1 check passed
@sapatevaibhav sapatevaibhav added gssoc Girl Script Summer of Code level2 Medium to solve issues for GSSoC'24 labels Jul 2, 2024
@VITianLalit VITianLalit deleted the explore_page_better branch July 2, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Girl Script Summer of Code level2 Medium to solve issues for GSSoC'24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants