Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoders with inner multi_temporal_strategy when using LTAE #97

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

gle-bellier
Copy link
Collaborator

Error:

  • Some encoders (e.g. satlasnet_mi) already merge information on the temporal dimension. Then, no multi_temporal_strategy is needed; if one is included in the configs, it will be skipped.
  • When using the LTAE, the decoder input channels are changed to match LTAE output channels (LTAE only works with all inputs having the same number of channels)
  • The bug was that even if the LTAE was skipped, the decoder's input channels were modified, causing shape errors.

Fix: change decoder input channels if LTAE is used AND the encoder has a multi-temporal output.
(for both SegMTUPerNet and RegMTUPerNet)

@yurujaja yurujaja merged commit 5eb8684 into main Oct 17, 2024
1 check passed
@yurujaja yurujaja deleted the fix-satlasnet_mi-with-ltae branch October 18, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants