Feature/proxy multiple backends issue3 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 20, 2024 11:21
This implements support for multiple S3 backends. Based on the region that is provided in the request the proxy will select the backend to send the request to. BREAKING CHANGE: remove AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY and FAKES3PP_S3_PROXY_TARGET environment variables in favor of backend-config.yaml which allows specifying similar config per proxy backend. Same functionality can be achieved but the configuration needs to be specified in backend-config.yaml which is pointed to by environment variable `FAKES3PP_S3_BACKEND_CONFIG`.
Add a scenario where we mimic a full setup and where we verify which backend is reached.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
added 4 commits
November 20, 2024 13:39
bugfix: backend extraction for pre-signed URLS This adds test scenario's for using pre-signed URLs to perform GetObject API calls against multiple backends. It also fixes a bug since the selection of a backend was done int he proxy function but that causes issues as that is past the cleaning of the intial request. By extracting the backend prior to proxying we allow to identify the correct backend. refactor: dry for getting proxy endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow proxying multiple backends with selection via region attribute as detailed on #3
It also includes extra testing ground work and allows to run tests again a simple S3 server implemented in the Python moto library which can easily run on development stations and in Github workflows.