Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update #1

wants to merge 2 commits into from

Conversation

zhengj2007
Copy link
Member

Handle 'na' values in the conversion file and detect IRI and label of term/parent positions in the file based on column header, no need to set in the setting file.

Copy link
Collaborator

@johnwjudkins johnwjudkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the jar file, and it works, but I see that you replaced
private String settingFilename = "./test/setting.txt";
with
private String settingFilename = "/Users/jiezheng/Documents/VEuPathDB-git/ApiCommonData/Load/ontology/script/test-local/setting_test.txt";
in src/ontoTool/OntologyClassGeneratorOptions.java.
Do you want a relative path here instead of the full path?

@zhengj2007
Copy link
Member Author

zhengj2007 commented Jul 7, 2021

You can ignore it. It is the value I set for testing. No change for people to run the script. Both full path and relative one are working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants