Corey onboarding 4 #102
Open
Corey onboarding 4 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivial Merge to update Onboarding branch from Develop
Will's Onboarding Task
Zaara's Onboarding II
Update onboarding from develop
### Description software onboarding II ### Reviewers Tag reviewers. - Required:@MaxxWilson --- ### Changelog - added linh-onboarding ### Testing #### Automatic - tests works #### Manual - na ### Checklist - [x] Confirmed all tests pass on a clean build - [x] Added reviewers in Github - [x] Posted PR Summary to Discord PR's Channel - [ ] Ran uncrustify on any modified C++ files - [ ] Ran Colcon Lint for any modified CMakeLists.txt or Package.xml --------- Co-authored-by: Maxx Wilson <[email protected]>
# PR Summary PR Link: INSERT-LINK-HERE Issue Link: INSERT-LINK-HERE ### Description Add a single line summary describing the purpose of this PR. ### Reviewers Tag reviewers. - Required: - Optional: --- ### Changelog - Add a bulleted list of major changes ### Reviewer Guide This is the most important part! - No one is going to read every line of every PR, so you need to tell the reviewers what they are looking for. - Point out lines you want feedback on or feel unsure about. - Highlight major changes that other members need to know about. ### Testing #### Automatic - Describe test cases that are covered by unit tests #### Manual - Describe any manual testing (launch files, visualizations, etc.) ### Documentation - Link any relevant documentation ### Checklist - [ ] Confirmed all tests pass on a clean build - [ ] Added reviewers in Github - [ ] Posted PR Summary to Discord PR's Channel - [ ] Ran uncrustify on any modified C++ files - [ ] Ran Colcon Lint for any modified CMakeLists.txt or Package.xml
# PR Summary PR Link: INSERT-LINK-HERE Issue Link: INSERT-LINK-HERE ### Description Add a single line summary describing the purpose of this PR. ### Reviewers Tag reviewers. - Required: - Optional: --- ### Changelog - Add a bulleted list of major changes ### Reviewer Guide This is the most important part! - No one is going to read every line of every PR, so you need to tell the reviewers what they are looking for. - Point out lines you want feedback on or feel unsure about. - Highlight major changes that other members need to know about. ### Testing #### Automatic - Describe test cases that are covered by unit tests #### Manual - Describe any manual testing (launch files, visualizations, etc.) ### Documentation - Link any relevant documentation ### Checklist - [ ] Confirmed all tests pass on a clean build - [ ] Added reviewers in Github - [ ] Posted PR Summary to Discord PR's Channel - [ ] Ran uncrustify on any modified C++ files - [ ] Ran Colcon Lint for any modified CMakeLists.txt or Package.xml
# PR Summary PR Link: INSERT-LINK-HERE Issue Link: INSERT-LINK-HERE ### Description Add a single line summary describing the purpose of this PR. ### Reviewers Tag reviewers. - Required: - Optional: --- ### Changelog - Add a bulleted list of major changes ### Reviewer Guide This is the most important part! - No one is going to read every line of every PR, so you need to tell the reviewers what they are looking for. - Point out lines you want feedback on or feel unsure about. - Highlight major changes that other members need to know about. ### Testing #### Automatic - Describe test cases that are covered by unit tests #### Manual - Describe any manual testing (launch files, visualizations, etc.) ### Documentation - Link any relevant documentation ### Checklist - [ ] Confirmed all tests pass on a clean build - [ ] Added reviewers in Github - [ ] Posted PR Summary to Discord PR's Channel - [ ] Ran uncrustify on any modified C++ files - [ ] Ran Colcon Lint for any modified CMakeLists.txt or Package.xml
# PR Summary PR Link: #99 ### Description Removes linting from CMake. ### Reviewers - Required: @MaxxWilson --- ### Changelog - Removes linter flags from base CMake config. - Removes duplicate linter flags from motion planner CMake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Link: INSERT-LINK-HERE
Issue Link: INSERT-LINK-HERE
Description
Onboarding attempt 4 (trying onboarding3 branch instead of regular onboarding branch)
Reviewers
Tag reviewers.
Required:
Optional:
Changelog
Reviewer Guide
This is the most important part!
Testing
Automatic
Manual
Documentation
Checklist