Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onboarding need review #100

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

Fyfth
Copy link
Collaborator

@Fyfth Fyfth commented Oct 13, 2024

PR Summary

PR Link: INSERT-LINK-HERE

Issue Link: INSERT-LINK-HERE

Description

Add a single line summary describing the purpose of this PR.

Reviewers

Tag reviewers.


Changelog

  • Add a bulleted list of major changes

Reviewer Guide

This is the most important part!

  • No one is going to read every line of every PR, so you need to tell the reviewers what they are looking for.
  • Point out lines you want feedback on or feel unsure about.
  • Highlight major changes that other members need to know about.

Testing

Automatic

  • Describe test cases that are covered by unit tests

Manual

  • Describe any manual testing (launch files, visualizations, etc.)

Documentation

  • Link any relevant documentation

Checklist

  • Confirmed all tests pass on a clean build
  • Added reviewers in Github
  • Posted PR Summary to Discord PR's Channel
  • Ran uncrustify on any modified C++ files
  • Ran Colcon Lint for any modified CMakeLists.txt or Package.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants