Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use siri:FareClass instead of own TravelClass enumeration #354

Merged
merged 7 commits into from
Apr 17, 2023

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Apr 13, 2023

fixes: #351

new:
SIRI-CEN/SIRI#109

@ue71603 ue71603 added the bug Something isn't working label Apr 13, 2023
@ue71603 ue71603 added this to the v2.0 milestone Apr 13, 2023
@ue71603 ue71603 requested a review from skinkie April 13, 2023 22:35
@ue71603 ue71603 changed the title add unknown to TravelClass TravelClass -> siri:FareClass Apr 14, 2023
@ue71603
Copy link
Contributor Author

ue71603 commented Apr 14, 2023

@Aurige Why was it changed originally? Is using the SIRI stuff a good idea here

Aurige
Aurige previously approved these changes Apr 15, 2023
@Aurige
Copy link
Contributor

Aurige commented Apr 15, 2023

@Aurige Why was it changed originally? Is using the SIRI stuff a good idea here

That's Ok, the SIRI enumeration is the exact same one as the NeTEx one :-)

@ue71603 ue71603 requested a review from AndreasAtSBB April 17, 2023 09:07
Copy link

@AndreasAtSBB AndreasAtSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travel to Fare change. Looks fine!

@skinkie
Copy link
Contributor

skinkie commented Apr 17, 2023

@Aurige or @sgrossberndt to merge.

@sgrossberndt sgrossberndt changed the title TravelClass -> siri:FareClass Use siri:FareClass instead of own TravelClass enumeration Apr 17, 2023
@sgrossberndt sgrossberndt merged commit 43c2d7b into changes_for_v1.1 Apr 17, 2023
@sgrossberndt sgrossberndt deleted the TravelClassFix branch April 17, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working doc updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants