Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict JSON schema for orders #11

Open
wants to merge 3 commits into
base: 5.0.0
Choose a base branch
from

Conversation

ralienpp
Copy link

This pull request aims to address this issue #10 and it adds a few improvements. It creates a better "safety cushion", by making the JSON schema more strict. This enables us to easily and immediately catch some types of errors.

changes:

  • is refactored a bit, to avoid duplication and facilitate reuse
  • provides comments in some tricky places to make it easier to follow the schema's logic
  • enforces the presence of at least 1 node in an order
  • enforces an ISO8601 timestamp format
  • enforces the presence of actionParameters in the cases when actionType is a standardized action which has mandatory parameters (actions without parameters and proprietary actions are not going to be verified)

Although this update makes the schema better, one should still perform post-hoc validation when complex logic is involved.

ralienpp and others added 3 commits September 24, 2020 16:42
Change quotes in a `description` field, otherwise the syntax is broken
This change aims to address the following issue: VDA5050#4

According to the specification, `allowedDeviation` is not a part of the order's data structure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant