Iss71 #72
Open
Iss71 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awunderground
requested changes
Mar 25, 2024
There was a problem hiding this comment.
Big-Picture Requests
- Write tests for each added change
- Run README.qmd to update README.md
Big-Picture Thoughts
- Grouping with the other functions uses unquoted variable names. Your changes use quoted variable names. How tough is this to change?
- The functions don't include the number of observations associated with each subgroup. This would be useful because small groups could be very noisy.
| .source = factor(c("training", "testing"), levels = c("training", "testing")), | ||
| .specks = c(specks_training, specks_testing) | ||
| ) | ||
| if (length(group)==0){ # original case |
There was a problem hiding this comment.
I think there is a way to implement this that doesn't use if-else. Instead, have it create two rows without groups and more rows with groups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding grouping functionality to discriminant-based metrics