Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: <p> font sizes #119

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Fix: <p> font sizes #119

merged 2 commits into from
Dec 17, 2024

Conversation

mitchthorson
Copy link
Contributor

@mitchthorson mitchthorson commented Dec 14, 2024 •
edited
Loading

What's in this pull request

  • Bug fix
  • New component/feature
  • Component update
  • Documentation update
  • Other

Description

This PR adds more CSS specificity to several component-level

tag styles to avoid conflicts with the defaults.

Before submitting, please check that you've

  • Formatted your code correctly (i.e., prettier cleaned it up)
  • Documented any new components or features
  • Added any changes in this PR to the CHANGELOG.md Next section
  • If this pull request includes a new component or feature, has it been exported from one of the library's entry points?
  • Does the component dispatch relevant interaction events? (ie: on:click, on:change, etc.)
  • Does the component directory include description and usage information in .stories.svelte?

@mitchthorson mitchthorson marked this pull request as ready for review December 14, 2024 20:19
rachelmarconi
rachelmarconi approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@rachelmarconi rachelmarconi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your time on this!

@mitchthorson mitchthorson merged commit 9ed60a0 into main Dec 17, 2024
1 check passed
@mitchthorson mitchthorson deleted the fix-font-sizes branch December 17, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelmarconi rachelmarconi rachelmarconi approved these changes

@benkates benkates benkates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitchthorson @benkates @rachelmarconi