Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add layercake components, stories and docs #111

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

rachelmarconi
Copy link
Contributor

@rachelmarconi rachelmarconi commented Aug 8, 2024

What's in this pull request

  • New component/feature

Description

Adding Layercake axes components according to what was used in the medical debt project.

NOTE: the axis components have since been updated on Layercake, so we can update further or not. Some of the new parameters could be very useful. New AxisX. New AxisY.

TODO:

  • add code chunks for css if updating manually

Before submitting, please check that you've

  • Formatted your code correctly (i.e., prettier cleaned it up)
  • Documented any new components or features
  • Added any changes in this PR to the CHANGELOG.md Next section
  • If this pull request includes a new component or feature, has it been exported from one of the library's entry points?
  • Does the component dispatch relevant interaction events? (ie: on:click, on:change, etc.)
  • Does the component directory include description and usage information in .stories.svelte?

@rachelmarconi rachelmarconi marked this pull request as ready for review August 8, 2024 21:54
Copy link
Contributor

@mitchthorson mitchthorson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good! I left a few organizational comments and a few nitty-gritty technical comments. Let me know if you want to talk through any of the details here!

src/lib/Layercake/AxisX.docs.md Outdated Show resolved Hide resolved
src/lib/Layercake/AxisX.docs.md Outdated Show resolved Hide resolved
src/lib/Layercake/AxisY.docs.md Outdated Show resolved Hide resolved
src/lib/Layercake/AxisY.docs.md Outdated Show resolved Hide resolved
src/lib/Layercake/AxisX.svelte Outdated Show resolved Hide resolved
src/lib/Layercake/AxisX.stories.svelte Outdated Show resolved Hide resolved
src/lib/Layercake/AxisX.svelte Outdated Show resolved Hide resolved
src/lib/Layercake/AxisY.stories.svelte Outdated Show resolved Hide resolved
src/lib/Layercake/AxisY.stories.svelte Outdated Show resolved Hide resolved
src/lib/Layercake/AxisY.svelte Outdated Show resolved Hide resolved
@@ -23,6 +23,7 @@ const preview = {
["Theme", "Fonts"],
"Examples",
"Components",
"Layercake",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok just one tiny last suggestion: to have the "Intro" page listed at the top of the Layercake section, just add one additional line below "Layercake" here:

...
"Layercake",
 ["Intro"],
...

Which should result in this ordering:

Screenshot 2024-08-28 at 12 59 39 PM

@rachelmarconi rachelmarconi merged commit d70506a into main Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants