Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add IconLibrary docs and components #110

Merged
merged 23 commits into from
Aug 29, 2024
Merged

add IconLibrary docs and components #110

merged 23 commits into from
Aug 29, 2024

Conversation

rachelmarconi
Copy link
Contributor

@rachelmarconi rachelmarconi commented Jul 26, 2024 •
edited
Loading

What's in this pull request

  • New component/feature

Description

Adding Icon components as a source of truth. No click events expected for icons.

Before submitting, please check that you've

  • Formatted your code correctly (i.e., prettier cleaned it up)
  • Documented any new components or features
  • Added any changes in this PR to the CHANGELOG.md Next section
  • If this pull request includes a new component or feature, has it been exported from one of the library's entry points?
  • Does the component dispatch relevant interaction events? (ie: on:click, on:change, etc.)
  • Does the component directory include description and usage information in .stories.svelte?

@rachelmarconi rachelmarconi added the new-feature New feature or request label Jul 26, 2024
@rachelmarconi rachelmarconi marked this pull request as ready for review July 29, 2024 20:28
rachelmarconi and others added 17 commits July 30, 2024 14:03
@rachelmarconi
created individual icon story files with preview stories for icongallery
5e46a96
@rachelmarconi
remove standalone search docs
3305ffc
@rachelmarconi
rename IconLibrary -> Icons
08db47a
@rachelmarconi
correct story configuration
079c7b9
@rachelmarconi
clean up docs text
f197ef7
@rachelmarconi
reorganize
55eff57
@benkates
init patch icon setup
a4f9511
@benkates
add manager styles
0a239ca
@benkates
add icons as export
d38497d
@benkates
update icon gallery style
5268022
@benkates
remove boilerplate from other icons
f79459c
@benkates
vertically align theme item
d81d2fd
@rachelmarconi
Merge pull request #112 from UrbanInstitute/patch-icon-library
4d366cf 
Icon gallery reorganization
@rachelmarconi
separate story for plus canvas
2ad62c4 
otherwise, since both the options icon and the controls both reference the Default story, any changes via controls affect the options icon, as well. I'd rather keep the options all neat and tidy, equal size and black, even if the user is messing around.
@rachelmarconi
Merge branch 'main' into feature-icon-library
427db15
@rachelmarconi
add a refresh icon
81710e1
@benkates
remove <Template> when unnecessary in icon stories files
2ac2cfe
@rachelmarconi rachelmarconi merged commit 5ea948c into main Aug 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benkates benkates benkates approved these changes

@mitchthorson mitchthorson Awaiting requested review from mitchthorson

Assignees
No one assigned
Labels
new-feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rachelmarconi @benkates