Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return to top component #11

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Return to top component #11

merged 6 commits into from
Jan 9, 2024

Conversation

benkates
Copy link
Contributor

@benkates benkates commented Jan 9, 2024

Would like some support on the following:

  • should we provide a sample story with a div that demonstates the functionality?
  • click/kepress are exposed for GA tracking, should this "Events" section be ignored in the story docs?

@benkates benkates requested a review from mitchthorson January 9, 2024 17:49
@benkates benkates changed the title init return top element Return to top component Jan 9, 2024
@benkates
Copy link
Contributor Author

benkates commented Jan 9, 2024

Also wondering if the arrow.svg should be included in the component folder itself or elsewhere

Inlined to avoid this

src/lib/ReturnTop/ReturnTop.svelte Outdated Show resolved Hide resolved
src/lib/ReturnTop/ReturnTop.svelte Outdated Show resolved Hide resolved
@mitchthorson
Copy link
Contributor

A sample story is also a great idea, could be a good use-case for a storybook play function, but not necessarily a requirement to merging this in here if it's not straight-forward.

Also, I think listing the events that are forwarded in the storybook like this is great. A quick and easy way to know what is available when using the component without manually documenting it elsewhere.

@benkates
Copy link
Contributor Author

benkates commented Jan 9, 2024

A sample story is also a great idea, could be a good use-case for a storybook play function, but not necessarily a requirement to merging this in here if it's not straight-forward.

Also, I think listing the events that are forwarded in the storybook like this is great. A quick and easy way to know what is available when using the component without manually documenting it elsewhere.

Thanks @mitchthorson - makes sense, let's circle pack to storybook play if it makes sense for more components in the future! And heard on the events! Thanks.

@mitchthorson mitchthorson merged commit b3ce55a into main Jan 9, 2024
1 check passed
@benkates benkates deleted the bk-return-top branch January 9, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants