Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: sourcecode link for components #107

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Feature: sourcecode link for components #107

merged 5 commits into from
Jul 12, 2024

Conversation

benkates
Copy link
Contributor

@benkates benkates commented Jul 11, 2024

What's in this pull request

  • Documentation update

Description

Adds GitHub link for component sourcecode plugin link here. Opening a PR on init commit to start the conversation. Recommendation to link directly to the component .svelte file.

This will be a manual add for each story since the "auto" feature in this plugin uses the storybook page route to build the GH link. I think this would be worth it!

Edit: Completed. Implemented with addon for .stories files and manual github icon/link add to .docs.mdx.

Before submitting, please check that you've

  • Added any changes in this PR to the CHANGELOG.md Next section

@benkates benkates requested a review from mitchthorson July 11, 2024 20:02
Copy link
Contributor

@mitchthorson mitchthorson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny tweak needed here i think

src/lib/Theme/Theme.docs.mdx Outdated Show resolved Hide resolved
@benkates benkates merged commit 3d31c4a into main Jul 12, 2024
1 check passed
@benkates benkates deleted the feature-source-link branch July 12, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants