Merge pull request #71 from UrbanInstitute/navbar-projectUrl-tweak

added case for no projectUrl
UrbanInstitute · Apr 19, 2024 · 113b4f3 · 113b4f3
2 parents b054132 + 6e2d031
commit 113b4f3
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@
 - Fixes package name in documentation
 - Fixes Intro code chunk to be up to date
 - Changes snake_case variables to camelCase
+- Add Navbar case for no projectUrl with story documentation
 
 ## v0.7.1
 

diff --git a/src/lib/Navbar/Navbar.stories.svelte b/src/lib/Navbar/Navbar.stories.svelte
@@ -35,7 +35,14 @@
 <Story name="Default" />
 
 <Story
-  name="With title"
+  name="With title, no project link"
+  args={{
+    title: "Project title"
+  }}
+/>
+
+<Story
+  name="With title and project link"
   args={{
     title: "Project title",
     projectUrl: "https://urban.org"
@@ -55,7 +62,7 @@
   name="TPC"
   args={{
     title: "Project title",
-    projectUrl: "https://urban.org",
+    projectUrl: "https://taxpolicycenter.org",
     brand: "tpc"
   }}
 />
diff --git a/src/lib/Navbar/Navbar.svelte b/src/lib/Navbar/Navbar.svelte
@@ -12,7 +12,7 @@
    * URL to link to from the title
    * @type {string}
    */
-  export let projectUrl;
+  export let projectUrl = "";
 
   /**
    * Brand to use for the logo
@@ -40,9 +40,13 @@
     </a>
   </div>
   {#if title}
+    {#if projectUrl}
     <a href="{projectUrl}/">
       <p class="nav--page-title">{title}</p>
     </a>
+    {:else}
+    <p class="nav--page-title">{title}</p>
+    {/if}
   {/if}
 </nav>