-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
1. If the default was prevented, then performed, we were no longer checking to make sure it wasn't already added to the list of choices. This meant that if the implementor added it themselves it would be then added twice 2. The UI behavior performed once a choice was added was being grouped into the performDefault function, meaning if the implementor wanted to update the model themselves and prevented default, the UI would be out of sync. I've pulled that out of the performDefault function and now always do it since it has nothing to do with the data model
- Loading branch information
1 parent
66c3175
commit f685d5c
Showing
3 changed files
with
24 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters