Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for "Simulator device set" #25

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

RobinDaugherty
Copy link

This is an attempt to address #24.

Mussel client infers the device set based on the HOME environment variable, which contains a path to the application within the Simulator. If it contains the string "XCTestDevices", then we use the device set name "testing". However, this could be changed to specify the path of the device set instead of the magic name "testing" by truncating it.

I changed the client to use a base class instead of protocol so that shared behavior can be written once. Identifying the current simulator ID and device set are in the base class. The base class implements the serverRequest(task:options:) method, and layers in these two items.

On the server, if a request includes the new option, it's used in the simctl command line. I also changed this to fail early if the weak self has gone away, rather than return a success status.

@ridvank
Copy link

ridvank commented Mar 1, 2023

This is what we are missing too unfortunately, is this repo still active? If yes, it would be amazing to merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants