Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy #13

Merged
merged 7 commits into from
Jun 12, 2021
Merged

Policy #13

merged 7 commits into from
Jun 12, 2021

Conversation

SoorajModi
Copy link
Collaborator

@SoorajModi SoorajModi commented May 29, 2021

Describe the pull request:

  • Policy page of the SOCIS website
  • Added policy documents under src/assets
  • Title of page as well as last update displayed at the top of the page
  • Added Constitution, Committee and Staff Policy, Club Space Policy, and Makers Space Policy
  • Displayed pdf using object html tag, if the user does not have the required plugin a link to download the pdf is displayed

Closes: #3
Fixes: #
Related: #


Checklist:

  • Run yarn test and ensure tests pass
  • Run yarn lint and ensure linter passes
  • Verify the changes work as expected on at least two browsers
  • Verify the changes work as expected on mobile view
  • Update documentation / not applicable

@SoorajModi SoorajModi requested a review from BenPearo May 29, 2021 02:50
@SoorajModi SoorajModi self-assigned this May 29, 2021
return (
<div>
<h1 style={styles.title}>SOCIS Policies</h1>
<p style={styles.subtext}>Last updated May 28, 2021</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to dynamically change this date based on modification times on the files?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not I can approve

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would either need to implement a backend or use an existing webhook provided by Github. According to this stack overflow post it is fairly straightforward.

However, it would add a decent amount of complexity to my already large PR and I would rather make it a separate issue and deal with it later on. I opened #16, and we can deal with it on the next milestone?

@SoorajModi SoorajModi requested a review from BenPearo May 30, 2021 21:18
@SoorajModi SoorajModi merged commit deae4e0 into main Jun 12, 2021
@SoorajModi SoorajModi deleted the 3-policy branch June 12, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Policy Page
2 participants