-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policy #13
Policy #13
Conversation
return ( | ||
<div> | ||
<h1 style={styles.title}>SOCIS Policies</h1> | ||
<p style={styles.subtext}>Last updated May 28, 2021</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to dynamically change this date based on modification times on the files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not I can approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would either need to implement a backend or use an existing webhook provided by Github. According to this stack overflow post it is fairly straightforward.
However, it would add a decent amount of complexity to my already large PR and I would rather make it a separate issue and deal with it later on. I opened #16, and we can deal with it on the next milestone?
Describe the pull request:
src/assets
object
html tag, if the user does not have the required plugin a link to download the pdf is displayedCloses: #3
Fixes: #
Related: #
Checklist:
yarn test
and ensure tests passyarn lint
and ensure linter passes