Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added navcon files #1

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

sweet235
Copy link

@sweet235 sweet235 commented Dec 7, 2022

I added a few manual navigation connections, most noticably down from the pipes in the default alien base (a natural place to build eggs at) and down from the cavity in the central room (where humans build occasionally). A few other connections are from crates to the floor.

@sweet235
Copy link
Author

sweet235 commented Dec 7, 2022

Disclaimer: I am not sure if the map package is a good place for these files. Maybe we can clarify where these files should go if they go into a release version.

Edit:
On IRC, I said this:

<Sweet0> however, i am not convinced that the map repo is the proper place for these files
<Sweet0> especially if we are going to remove navmesh files from map packages
<Sweet0> then it does not seem sensible to have other bot files there
<Sweet0> also, changing the bot code might require changes to the navcons (they work with current bot code)
<Sweet0> so it would seem awkwardly complicated to have to change the map package once the bot code changes in an impactful way

@illwieckz
Copy link
Member

Navcon in map package looks fine to me, we can see them as part of the map source.

Though, we may want a diffable format: Unvanquished/Unvanquished#1772

@sweet235 sweet235 marked this pull request as draft December 7, 2022 10:27
@sweet235
Copy link
Author

sweet235 commented Dec 7, 2022

Converted to draft until I feel we reached unanimous consenus.

@ghost
Copy link

ghost commented Apr 9, 2023

ping

@ghost
Copy link

ghost commented May 19, 2023

obsolete, we now use text-based format?

@illwieckz
Copy link
Member

Some navcons already have been merged, but there may be updates to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants