-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux: store QSettings in a single location #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Can you note why Windows is different than the unixes? |
Done. |
I still don't understand the reasoning? Is it that the name "Unvanquished Development" is better on Windows? |
With the organization name, actually Mac and Windows are the same and Linux will now be different. Previously, we chose the |
Please comment this rationale in the code and/or the commit message. LGTM. |
Fixes the Linux part of Unvanquished#121. Choose the location of our settings by changing the default location for settings, rather than customizing the parameter of our settings object. This makes it so the settings added by a component we depend on end up in the same place. Some more explanation quoted from the Github thread: > I still don't understand the reasoning? Is it that the name "Unvanquished Development" is better on Windows? > With the organization name, actually Mac and Windows are the same and Linux will now be different. Previously, we chose the unvanquished/updater path to store the main settings of the updater. Some stuff was stored in an Unvanquished Development/Unvanquished Updater path by accident; I want to stop that. We need to go with the lowercase one to maintain compatibility with the previous version of the updater. But yes, the lowercase ones seem more in line with Linux stylistic conventions.
Fixes the Linux part of #121. Choose the location of our settings by changing the default location for settings, rather than customizing the parameter of our settings object. This makes it so the settings added by a component we depend on end up in the same place.