Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fixed action properties editor UI (ISXB-1277) #2083

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

bmalrat
Copy link
Collaborator

@bmalrat bmalrat commented Dec 9, 2024

Description

Action properties does not try to fit all fields by not forcing a minimum size

Testing status & QA

base IMGUI :
Screenshot 2024-12-03 165758

before UI Toolkit:
Screenshot 2024-12-04 103135

tested with 2022.3 and 6000.0 now UI Toolkit:
Screenshot 2024-12-09 112440

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity: 0
  • Halo Effect: 0

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • [X ] Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@bmalrat bmalrat requested a review from Pauliusd01 December 9, 2024 19:25
@bmalrat bmalrat changed the title FIX: Fixed action properties editor UI FIX: Fixed action properties editor UI (ISXB-1277) Dec 9, 2024
@bmalrat bmalrat force-pushed the isxb-1278-fix-action-properties-editor-ui branch from 2714c49 to 7380847 Compare December 9, 2024 19:28
Copy link
Collaborator

@lyndon-unity lyndon-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable change to fix the formatting.

@Pauliusd01
Copy link
Collaborator

With the minimum action window size the panel is still too small. Maybe requires upping that window minimum as well?
image

@bmalrat
Copy link
Collaborator Author

bmalrat commented Dec 10, 2024

With the minimum action window size the panel is still too small. Maybe requires upping that window minimum as well? image

Good catch I updated it

Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked it in the PWA view and custom input actions window. I did notice one small thing, the draggable action properties line gets thicker when the panel is at its max size (see video) but it seems so minor I wouldn't mind if It's kept as is

11.12.2024.-.Unity.72.mp4

@bmalrat bmalrat merged commit d5f8543 into develop Dec 12, 2024
77 checks passed
@bmalrat bmalrat deleted the isxb-1278-fix-action-properties-editor-ui branch December 12, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants